Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up config and app API #3197

Merged
merged 11 commits into from
May 3, 2024
Merged

Clean up config and app API #3197

merged 11 commits into from
May 3, 2024

Conversation

picklelo
Copy link
Contributor

Begin moving things to private methods when we don't want to expose them, and removing things that were deprecated. This is with the goal of getting our API reference to be higher quality.

reflex/app.pyi Outdated
Copy link
Collaborator

@Lendemor Lendemor Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be more changes in this file with how many functions have been renamed in app.py ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the app.pyi completely now

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to revert a recent PR to remove socket_app and respect the user's sio kwarg

reflex/app.py Outdated Show resolved Hide resolved
reflex/app.py Outdated Show resolved Hide resolved
picklelo and others added 2 commits May 2, 2024 09:56
Co-authored-by: Masen Furer <m_github@0x26.net>
Co-authored-by: Masen Furer <m_github@0x26.net>
@picklelo picklelo requested a review from martinxu9 May 2, 2024 16:57
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, thought i marked this earlier...

@picklelo picklelo merged commit 7903a10 into main May 3, 2024
46 checks passed
@picklelo picklelo deleted the nikhil/api-cleanup branch June 5, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants