[REF-2789] Graceful deprecation of rx.input.root and rx.input.input #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle previously valid code where rx.input.root wrapped rx.input/rx.input.input and rx.input.slot. Raise deprecation warnings with hints about how to refactor code. Copy props from rx.input.root to children inputs and apply any rx.input.slot components to children inputs in an attempt to keep existing code working as best as possible. Fix DebounceInput: * pass children through (for rx.input.slots) * pass _rename_props through (for color_scheme)
picklelo
reviewed
May 8, 2024
| if isinstance(child, (TextFieldRoot, DebounceInput)) | ||
| ] | ||
| slots = [child for child in children if isinstance(child, TextFieldSlot)] | ||
| carry_props = { |
There was a problem hiding this comment.
I think the event handlers may also need to be bubbled (based on the integration tests)
There was a problem hiding this comment.
hmm, i'm actually surprised that code sample in reflex-web actually worked before... i thought a root always needed an explicit input inside of it, but i guess not. will adjust
Fix for case where `rx.input.root` had no input children
picklelo
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle previously valid code where rx.input.root wrapped rx.input/rx.input.input and rx.input.slot.
Raise deprecation warnings with hints about how to refactor code.
Copy props from rx.input.root to children inputs and apply any rx.input.slot components to children inputs in an attempt to keep existing code working as best as possible.
Fix DebounceInput: