Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF-3149] Bring back py3.12 hot reload warning #3537

Merged
merged 2 commits into from
Jun 24, 2024
Merged

[REF-3149] Bring back py3.12 hot reload warning #3537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d2c4ac
[REF-3149] Bring back py3.12 hot reload warning
masenf Jun 20, 2024
bc57520
Merge branch 'main' into masenf/bring-back-py312-warning
Lendemor Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions reflex/utils/prerequisites.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,9 +955,10 @@ def needs_reinit(frontend: bool = True) -> bool:
console.warn(
"""Windows Subsystem for Linux (WSL) is recommended for improving initial install times."""
)
if sys.version_info >= (3, 12) and uvi_ver != "0.24.0.post1":
if sys.version_info >= (3, 12):
console.warn(
f"""On Python 3.12, `uvicorn==0.24.0.post1` is recommended for improved hot reload times. Found {uvi_ver} instead."""
"Python 3.12 on Windows has known issues with hot reload (reflex-dev/reflex#3536). "
"Python 3.11 is recommended with this release of Reflex."
)

if sys.version_info < (3, 12) and uvi_ver != "0.20.0":
Expand Down
Loading