dedupe config overrides #3600
Merged
dedupe config overrides #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking the message for config override would be more pertinent at the DEBUG level rather than INFO, what do you think? |
|
I actually like that this is INFO, and with this PR it's not that disturbing, because it's only shown once on startup. But if you and your team like DEBUG more, i can adjust it for you. |
masenf
approved these changes
Jul 2, 2024
|
Hmm, true, with dedupe, info will be less spammy yeah. Guess it's fine like this 👍 |
Lendemor
approved these changes
Jul 3, 2024
Alek99
pushed a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3599