[REF-3135]Radix Primitive components should not ignore provided class_name
prop
#3676
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for radix primitives, the
class_name
is set to the tag name of the component, so if you provide a class-name for a primitive component(eg.rx.form
), the provided class name will be stripped off or overridden.With this PR, we respect the provided class_name which now allows us to achieve something like this:
The renderered js code is now: