Fix type propagation in ToStringOperation

[abulvenz]

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Does your submission pass the tests?

closes #3890

[abulvenz]

@benedikt-bartscher I haven't had a look into our PositiveInt class so far. Maybe ToNumberOperation can also be enhanced by a similar change.

[benedikt-bartscher]

@benedikt-bartscher I haven't had a look into our PositiveInt class so far. Maybe ToNumberOperation can also be enhanced by a similar change.

I see no good reason to not propagate the specialized type for ints as well

[abulvenz]

When looking into NumberOperations I found this asymmetry. Maybe that would be an even better fix?
@benedikt-bartscher @masenf Can somebody judge this?

        if issubclass(fixed_type, bool):
            return self.to(BooleanVar, self._var_type)
        if issubclass(fixed_type, (int, float)):
            return self.to(NumberVar, self._var_type)
        if issubclass(fixed_type, dict):
            return self.to(ObjectVar, self._var_type)
        if issubclass(fixed_type, (list, tuple, set)):
            return self.to(ArrayVar, self._var_type)
        if issubclass(fixed_type, str):
            return self.to(StringVar)   # var_type not propagated here !!!
        if issubclass(fixed_type, Base):
            return self.to(ObjectVar, self._var_type)
        return self

[benedikt-bartscher]

When looking into NumberOperations I found this asymmetry. Maybe that would be an even better fix? @benedikt-bartscher @masenf Can somebody judge this?

        if issubclass(fixed_type, bool):
            return self.to(BooleanVar, self._var_type)
        if issubclass(fixed_type, (int, float)):
            return self.to(NumberVar, self._var_type)
        if issubclass(fixed_type, dict):
            return self.to(ObjectVar, self._var_type)
        if issubclass(fixed_type, (list, tuple, set)):
            return self.to(ArrayVar, self._var_type)
        if issubclass(fixed_type, str):
            return self.to(StringVar)   # var_type not propagated here !!!
        if issubclass(fixed_type, Base):
            return self.to(ObjectVar, self._var_type)
        return self

I am not (yet) deep into the new var system, but that sounds like a better approach, and it seems like you already migrated to it?

[abulvenz]

Mmh, locally the integration-app-harness tests are passing.

[benedikt-bartscher]

Mmh, locally the integration-app-harness tests are passing.

you need to merge main, fixed in #3902

[abulvenz]

Thanks @masenf and @benedikt-bartscher. Now I can sleep peacefully 😃