Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add special handling for infinity and nan #3943

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Conversation

adhami3310
Copy link
Member

No description provided.

@adhami3310 adhami3310 requested a review from masenf September 17, 2024 20:11
reflex/vars/number.py Outdated Show resolved Hide resolved
masenf
masenf previously approved these changes Sep 18, 2024
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test here would be nice

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tks

@adhami3310 adhami3310 merged commit 91b50d7 into main Sep 18, 2024
46 checks passed
masenf pushed a commit that referenced this pull request Sep 20, 2024
* add special handling for infinity and nan

* use custom exception

* add test for inf and nan
@masenf masenf deleted the handle-inf-and-nan branch December 12, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants