Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all runtime asserts #4019

Merged
merged 2 commits into from
Sep 28, 2024
Merged

remove all runtime asserts #4019

merged 2 commits into from
Sep 28, 2024

Conversation

Lendemor
Copy link
Collaborator

No description provided.

masenf
masenf previously approved these changes Sep 27, 2024
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally id say we should raise trackable exceptions here, but since these were originally assert, maybe they're not intended to ever be hit?

reflex/testing.py Outdated Show resolved Hide resolved
Co-authored-by: Masen Furer <m_github@0x26.net>
@Lendemor
Copy link
Collaborator Author

normally id say we should raise trackable exceptions here, but since these were originally assert, maybe they're not intended to ever be hit?

I think so yes.
That said, if there is any that should have more specific name, I don't mind changing them, I was just not very inspired for renaming since there is quite a few of them.

@masenf masenf merged commit 23e9797 into main Sep 28, 2024
39 checks passed
@masenf masenf deleted the lendemor/remove_runtime_asserts branch September 28, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants