-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let users pick state manager mode #4041
Conversation
I prefer passing the StateManager subclass itself rather than an enum because that allows one to pass any subclass, including custom defined ones. |
I would be fine with this, but how would it work for setting it via env var? |
the developer can special case on env var they give (like if is_prod use this else use sth else), i don't think we should support direct env var to set this |
If we define it in Config it'll automatically accept the related env var, I'm not sure we have a mechanism to exclude some config field. |
wild, didn't even know we had that feature
how would it even accept an env field for a non-trivially-serializable object like this? would it skip it? |
As a note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
In
rx.Config
instance, you can now pass a value between"disk", "memory" or "redis"
tostate_manager_mode