Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move router dataclasses in their own file #4044

Merged
merged 1 commit into from
Oct 3, 2024
Merged

move router dataclasses in their own file #4044

merged 1 commit into from
Oct 3, 2024

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Oct 2, 2024

No description provided.

@adhami3310
Copy link
Member

Can we pick a better name than istate 😭

@Lendemor
Copy link
Collaborator Author

Lendemor commented Oct 3, 2024 •
edited
Loading

Can we pick a better name than istate 😭

Sure, if you've got a better suggestion I can change it 👍

Though it's just a temporary name until we finish breaking down state.py into smaller files.

adhami3310
adhami3310 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@adhami3310 adhami3310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can't think of something better than istate (should prob be state once the reorganizing is done)

@masenf masenf merged commit 40f1880 into main Oct 3, 2024
39 checks passed
Kastier1 pushed a commit that referenced this pull request Oct 23, 2024
@Lendemor
move router dataclasses in their own file (#4044)
eb5210c
@masenf masenf deleted the lendemor/start_splitting_state_py branch December 12, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhami3310 adhami3310 adhami3310 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lendemor @adhami3310 @masenf