[ENG-2287] Avoid fetching same state from redis multiple times #4055
+33
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the presence of computed vars, substates may be cached more than once.
masenf
force-pushed
the
masenf/optimize-redis-get-state
branch
from
cc00e56 to
42f8fcf
Compare
adhami3310
previously approved these changes
Oct 4, 2024
masenf
commented
Oct 4, 2024
reflex/state.py
Outdated
| @@ -2974,39 +2985,29 @@ async def get_state( | |||
| if redis_state is not None: | |||
| # Deserialize the substate. | |||
| state = BaseState._deserialize(data=redis_state) | |||
There was a problem hiding this comment.
need to catch schema mismatch error
If the serialized state's schema does not match the current corresponding state schema, then we have to create a new instance.
Lendemor
approved these changes
Oct 7, 2024
Kastier1
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Avoid fetching substates multiple times In the presence of computed vars, substates may be cached more than once. * Consolidate logic in StateManagerRedis.get_state * Suppress StateSchemaMismatchError and create a new state instance. If the serialized state's schema does not match the current corresponding state schema, then we have to create a new instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2950
When fetching a state from redis which has computed vars, it might get fetched twice when populating substates. To avoid this, pass a list of already-fetched substates to
get_stateand apply these before performingpopulate_substates. Thenpopulate_substatesskips fetching substates which are already in the tree.Consolidate logic between the "deserialize instance" and "create instance" paths -- previously we needed the other path, because we had to instantiate a new state class with a valid
parent_state, but with the merge of 319ff17, the parent_state pointer can be added later, so the two paths were equivalent.