Include step attribute in input #4073
Merged
+104
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
reviewed
Oct 7, 2024
| @@ -68,6 +68,8 @@ class TextFieldRoot(elements.Div, RadixThemesComponent): | |||
| # Specifies the type of input | |||
| type: Var[str] | |||
|
|
|||
| step: Var[int] | |||
There was a problem hiding this comment.
If this is being included for documentation purposes, please add a preceeding comment, which will be used to generate the docs for this component.
There was a problem hiding this comment.
@masenf Should i add the comment alone and push again?
it is inherited from Input, and does not need to be redefined
|
retrigger CI hopefully |
masenf
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the base class of Text field from rx.el.Div to rx.el.Input and added the step attribute.Works in the case of value and on_change events being given(i.e DebounceInput ).