Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First use environment variable as npm registry #4082

Merged
merged 2 commits into from
Oct 9, 2024
Merged

First use environment variable as npm registry #4082

merged 2 commits into from
Oct 9, 2024

Conversation

ruhz3
Copy link
Contributor

@ruhz3 ruhz3 commented Oct 7, 2024 •
edited
Loading

Type of change

When running reflex init, I have made adjustments to allow more flexible npm configurations, especially for environments where SSL verification is challenging or when using proxy remote repositories.

  1. If the NPM_REGISTRY environment variable is set, the specified path will be used first.(If it is not set, the existing logic based on latency will apply.)
  2. Instead of using httpx, we now use utilities implemented in net.

@ruhz3 ruhz3 changed the title First use environment variable as npm registry #4028 First use environment variable as npm registry Oct 7, 2024
masenf
masenf reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you considered NPM_CONFIG_REGISTRY as the knob? That would be more standardized and interoperable with npm environments.

@masenf masenf merged commit f3b8b2e into reflex-dev:main Oct 9, 2024
39 checks passed
Kastier1 pushed a commit that referenced this pull request Oct 23, 2024
@ruhz3
First use environment variable as npm registry (#4082)
2100cb4 
* First use environment variable as npm registry

* use NPM_CONFIG_REGISTRY as env variable

---------

Co-authored-by: 류형주/인공지능팀 <hyungju.ryu@ahnlab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reflex init in an environment without access to the npm registry requires 6 HTTP timeout to complete.
2 participants
@ruhz3 @masenf