Remove wrong event handlers #4136
Conversation
There was a problem hiding this comment.
Probably followup work, but the drawer content component accepts on_pointer_down_outside and on_open_auto_focus events.
Looks like the root also exposes on_close.
The docs for vaul are a bit out of date with the code; we probably should go through and clean these up.
| on_change: EventHandler[lambda e0: [e0.target.value]] | ||
| on_change: EventHandler[input_event] |
There was a problem hiding this comment.
if this class inherits from elements.Textarea, do we need these definitions here? are they for autodoc purposes?
There was a problem hiding this comment.
Soon TextField will inherit from elements.Input, so similar question there.
There was a problem hiding this comment.
removed unnecessary ones! should work fine as PYI file remained the same
it technically does, but also it's not documented in vaul, so we kinda agreed to leave it out |
* remove wrong target value * add keyboard event * simplify empty ones * remove events from text_area * empty tuples are empty bruh * dangit darglint
also deprecate default annotations for strings (which means there will be good amount of fixes to event handlers in the library soon)