Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the defalut direction of radio group #4146

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Change the defalut direction of radio group #4146

merged 1 commit into from
Oct 14, 2024

Conversation

Manojvbhat
Copy link
Contributor

@Manojvbhat Manojvbhat commented Oct 10, 2024 •
edited
Loading

Change the default direction of the radio group to horizontal.

All Submissions:

  • [ ✅ ] Have you followed the guidelines stated in CONTRIBUTING.md file?
  • [ ✅ ] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • [ ✅ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [✅ ] This change requires a documentation update

New Feature Submission:

  • [✅ ] Does your submission pass the tests?
  • [✅ ] Have you linted your code locally prior to submission?

@Manojvbhat
Change the defalut direction of radio group (reflex-dev#4070).
5de3416 
- The default direction of radio groups is column.
- Since most use cases are horizontal, change the default direction from
  column to row.
@Manojvbhat Manojvbhat changed the title Change the defalut direction of radio group (#4070). Change the defalut direction of radio group #4070 Oct 10, 2024
@Manojvbhat Manojvbhat changed the title Change the defalut direction of radio group #4070 Change the defalut direction of radio group Oct 10, 2024
@Manojvbhat Manojvbhat marked this pull request as draft October 10, 2024 04:44
@Manojvbhat Manojvbhat marked this pull request as ready for review October 11, 2024 04:20
@masenf masenf merged commit d6797a1 into reflex-dev:main Oct 14, 2024
31 checks passed
Kastier1 pushed a commit that referenced this pull request Oct 23, 2024
@Manojvbhat
Change the defalut direction of radio group (#4070). (#4146)
db1b214 
- The default direction of radio groups is column.
- Since most use cases are horizontal, change the default direction from
  column to row.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lendemor Lendemor Lendemor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Radio Group direction should default to row
3 participants
@Manojvbhat @Lendemor @masenf