allow setting run mode via env, add helpers to determine it #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benedikt-bartscher
added a commit
to benedikt-bartscher/reflex-chakra
that referenced
this pull request
Oct 13, 2024
Lendemor
reviewed
Oct 14, 2024
| Returns: | ||
| True if the app is running in frontend-only mode. | ||
| """ | ||
| return os.environ.get(constants.ENV_FRONTEND_ONLY_ENV_VAR, "").lower() == "true" |
There was a problem hiding this comment.
For some env vars, we're checking against ["true", "1", "yes"] rather than just "true".
I think it'd be better to have an uniform method doing the check for boolean env var rather than duplicating logic everywhere.
There was a problem hiding this comment.
Thanks for your review. I know, it's a mess currently. I think this needs a refactor over the whole repo, maybe we should address that one in a different PR later on.
There was a problem hiding this comment.
i created #4172 to discuss/refactor boolean env var handling
There was a problem hiding this comment.
Thanks for making that issue.
Yeah I'll approve this PR and we can clean up things over the whole repo in a different PR.
Closed
Lendemor
approved these changes
Oct 15, 2024
|
needs coordination with #4192 |
Kastier1
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bonus: error out if backend-only and frontend-only is set at the same time
needed here: reflex-dev/reflex-chakra#22