add type hinting to error boundary #4182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
approved these changes
Oct 22, 2024
| """Handle frontend exceptions. | ||
|
|
||
| If a frontend exception handler is provided, it will be called. | ||
| Otherwise, the default frontend exception handler will be called. | ||
|
|
||
| Args: | ||
| stack: The stack trace of the exception. | ||
| component_stack: The stack trace of the component where the exception occurred. |
There was a problem hiding this comment.
what does the component_stack get used for? it's not being passed to the registered exception handler
There was a problem hiding this comment.
it's not being used here, but it's provided by the react library
Kastier1
pushed a commit
that referenced
this pull request
Oct 23, 2024
* add type hinting to error boundary * remove logFrontendError * fix other calls to handle_frontend_exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.