Remove Duplicated 'gray' colour from ColorType #4249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features:
After these steps, you're ready to open a pull request.
This is a very small PR to remove a duplicate "gray" entry from the ColorType constant.
While browsing the code, I noticed a duplicate entry in the definition of ColorType and decided to open a PR to rectify it.
I considered adding a unit test to ensure that duplicates won't occur in the future, but this seems challenging due to the the Literal class in python, which parses input parameters using a
_deduplicate()
function that removes duplicate values. My attempts to check for duplicates in ColorType always returned that there were none, so I am holding off on this for now. Please let me know if you have any opinions or suggestions regarding this.Thank you.