Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Duplicated 'gray' colour from ColorType #4249

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

lb803
Copy link
Contributor

@lb803 lb803 commented Oct 26, 2024

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

This is a very small PR to remove a duplicate "gray" entry from the ColorType constant.

While browsing the code, I noticed a duplicate entry in the definition of ColorType and decided to open a PR to rectify it.

I considered adding a unit test to ensure that duplicates won't occur in the future, but this seems challenging due to the the Literal class in python, which parses input parameters using a _deduplicate() function that removes duplicate values. My attempts to check for duplicates in ColorType always returned that there were none, so I am holding off on this for now. Please let me know if you have any opinions or suggestions regarding this.

Thank you.

@picklelo
Copy link
Contributor

nice catch!

@picklelo picklelo merged commit 01ca426 into reflex-dev:main Oct 28, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants