redesign error boundary screen #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
reviewed
Nov 8, 2024
There was a problem hiding this comment.
this looks much better than the crap we had before, nice.
i think visually it might be better if it were in the top third rather than vertically centered on the page, but i'm not splitting hairs as i'm not a designer.
you should add the screenshots to the PR description and have @Alek99 / @carlosabadia take a look at it
|
|
|
@Alek99 @carlosabadia let me know if improvements can be made! Note this has to be implemented in pure HTML, as we don't get Radix in the fallback place. |
|
@masenf it doesn't seem we're getting feedback on this now, so we can merge it and redesign it later if needed |
|
didn't see this, sorry. Looks good to me! |
masenf
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.