new favicon, new blank template #4413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
reviewed
Nov 21, 2024
| @@ -16,19 +16,33 @@ def index() -> rx.Component: | |||
| return rx.container( | |||
| rx.color_mode.button(position="top-right"), | |||
| rx.vstack( | |||
| rx.heading("Welcome to Reflex!", size="9"), | |||
| rx.heading("Welcome to Reflex 🦕", size="9"), | |||
There was a problem hiding this comment.
i had three team members here in the office take a look at the new layout and they all said "why is there a dinosaur"
There was a problem hiding this comment.
I added a dinosaur to make the heading fancy, I can change it to "✨" if you want to.
adhami3310
requested changes
Nov 21, 2024
adhami3310
previously approved these changes
Nov 21, 2024
|
@adhami3310 This should be in the highest quality favicon possible right? |
yea i updated the one in the PR to contain no upscaling/compression effects, that is resolved ! |
|
I have improved the template with all the suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Type of change
This includes a new blank template and a higher quality 16kb favicon