[ENG-4137] Handle generic alias passing inspect.isclass check #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On py3.9 and py3.10, `dict[str, str]` and other typing forms are kinda considered classes, but they still fail when doing `issubclass`, so specifically exclude generic aliases before calling issubclass. Fix #4424 Bonus fix: support upcasting of pydantic v1 and v2 models
Lendemor
approved these changes
Nov 23, 2024
masenf
added a commit
that referenced
this pull request
Nov 25, 2024
On py3.9 and py3.10, `dict[str, str]` and other typing forms are kinda considered classes, but they still fail when doing `issubclass`, so specifically exclude generic aliases before calling issubclass. Fix #4424 Bonus fix: support upcasting of pydantic v1 and v2 models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On py3.9 and py3.10,
dict[str, str]and other typing forms are kinda considered classes, but they still fail when doingissubclass, so specifically exclude generic aliases before calling issubclass.Fix #4424
Bonus fix: support upcasting of pydantic v1 and v2 models
Adds some test coverage to this sorta dodgy bit of code that has already introduced at least 3 bugs since being added.