Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify redis code, less redis calls #4456

Merged
merged 3 commits into from
Dec 12, 2024
Merged

simplify redis code, less redis calls #4456

merged 3 commits into from
Dec 12, 2024

Conversation

benedikt-bartscher
Copy link
Contributor

No description provided.

@benedikt-bartscher
Copy link
Contributor Author

@masenf was there a specific reason to use redis.exists and not directly try_get_lock?

@benedikt-bartscher benedikt-bartscher marked this pull request as ready for review November 29, 2024 15:04
benedikt-bartscher
benedikt-bartscher commented Dec 1, 2024
View reviewed changes
reflex/state.py Outdated Show resolved Hide resolved
masenf
masenf approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@masenf masenf merged commit 1b6f539 into reflex-dev:main Dec 12, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lendemor Lendemor Lendemor approved these changes

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benedikt-bartscher @masenf @Lendemor