Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Checkbox component in Context Menu (partial fix for #4262) #4479

Merged
merged 19 commits into from
Dec 13, 2024

Conversation

vydpnguyen
Copy link
Contributor

@vydpnguyen vydpnguyen commented Dec 4, 2024

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

In context_menu.py, I added a new ContextMenuCheckbox class and initialized checkbox. Users can now use the checkbox like this:

checkbox-context-menu
c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

This pull request only fixes part of issue #4262.

@vydpnguyen vydpnguyen marked this pull request as draft December 5, 2024 16:54
@vydpnguyen vydpnguyen marked this pull request as ready for review December 6, 2024 01:09
@vydpnguyen vydpnguyen requested a review from Lendemor December 6, 2024 01:11
Copy link
Collaborator

@Lendemor Lendemor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After running it again locally, I have some more changes to suggest.

You should also run this : py scripts/make_pyi.py reflex/components/radix/themes/components/context_menu.py before doing the commit.

Run pre-commit install if you want the command above to check automatically.

vydpnguyen and others added 4 commits December 9, 2024 23:03
Co-authored-by: Thomas Brandého <thomas.brandeho@gmail.com>
Co-authored-by: Thomas Brandého <thomas.brandeho@gmail.com>
Co-authored-by: Thomas Brandého <thomas.brandeho@gmail.com>
Co-authored-by: Thomas Brandého <thomas.brandeho@gmail.com>
@vydpnguyen vydpnguyen marked this pull request as draft December 10, 2024 07:20
@vydpnguyen vydpnguyen marked this pull request as ready for review December 12, 2024 19:13
@Lendemor Lendemor merged commit 7208540 into reflex-dev:main Dec 13, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants