Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple mismatched-type-assignment fixes #4482

Merged

Conversation

benedikt-bartscher
Copy link
Contributor

@benedikt-bartscher benedikt-bartscher commented Dec 4, 2024

mismatched-type-assignment check did not strip rx.Field annotations and added a second optional for annotations which were already optional

@benedikt-bartscher benedikt-bartscher changed the title fix: only make type optional if it's not already, add helper to unwra… fix: multiple mismatched-type-assignment fixes Dec 4, 2024
@benedikt-bartscher benedikt-bartscher marked this pull request as ready for review December 4, 2024 23:05
@benedikt-bartscher
Copy link
Contributor Author

@adhami3310 iirc you implemented rx.Field, could you maybe review this for me?

reflex/state.py Outdated Show resolved Hide resolved
@masenf masenf merged commit 2520c51 into reflex-dev:main Dec 10, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants