Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test dynamic route flakiness (can't reproduce locally) #4496

Merged
merged 2 commits into from
Dec 6, 2024
Merged

test dynamic route flakiness (can't reproduce locally) #4496

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c2f975
test dynamic route flakiness (can't reproduce locally)
benedikt-bartscher Dec 6, 2024
65f9d66
fix typo
benedikt-bartscher Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/integration/test_dynamic_routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from __future__ import annotations

import time
from typing import Callable, Coroutine, Generator, Type
from urllib.parse import urlsplit

Expand Down Expand Up @@ -177,6 +178,8 @@ def driver(dynamic_route: AppHarness) -> Generator[WebDriver, None, None]:
"""
assert dynamic_route.app_instance is not None, "app is not running"
driver = dynamic_route.frontend()
# TODO: drop after flakiness is resolved
driver.implicitly_wait(30)
try:
yield driver
finally:
Expand Down Expand Up @@ -391,6 +394,9 @@ async def test_render_dynamic_arg(
with poll_for_navigation(driver):
driver.get(f"{dynamic_route.frontend_url}/arg/0")

# TODO: drop after flakiness is resolved
time.sleep(3)

def assert_content(expected: str, expect_not: str):
ids = [
"state-arg_str",
Expand Down
Loading