[ENG-3583] Respect cors_allowed_origins for backend HTTP requests #4533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test code
in
rxconfig.py
Running the app stateless with various combinations of
cors_allowed_origins
shows that CORS is now respected on the HTTP connection.CORS has been respected on the websocket connection for quite a while, but for some reason all origins were being allowed to other backend HTTP routes, like
_upload
andping
. Now those are protected by the starlette CORSMiddleware.