Support building with ghc-9.8 js backend #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps it would be better to rebase it onto #470 after it will be merged... |
Agreed, I only worried about building with newer ghc for use in a desktop app but this PR adds some JS specific stuff. |
alexfmpe
reviewed
Nov 2, 2024
| @@ -68,20 +68,20 @@ library | |||
| hs-source-dirs: src | |||
| build-depends: | |||
| aeson >= 0.8 && < 2.2, | |||
| base >= 4.7 && < 4.15, | |||
| base >= 4.7 && < 4.19, | |||
There was a problem hiding this comment.
Not sure what's with this bound since ghc 9.8 brings base 4.19
https://gitlab.haskell.org/ghc/ghc/-/wikis/commentary/libraries/version-history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes reflex-dom buildable by ghc-9.8 with js backend. To make resulting applications usable (eliminate JS errors), fixes in ghcjs-dom and ghcjs-base are also required.