Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the code for
Reflux.all
.I found the prior implementation, returning a hacked action, to be a bit dangerous. What we get back is both a listener and a publisher, which means it is really a store! By implementing it as such instead we get shorter code, and we can get rid of the extra
hasListener
method which was needed earlier since the action was moonlighting as a listener.As a bonus, by using
ListenerMethods.listenTo
instead of directly callingPublisherMethods.listen
, we get an object which can clean up itself.Less LOC:s, less debt and headache waiting to happen.
There is an ever so slight API breakage as we no longer get back a functor, but I doubt it was ever used in such a way.