Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of RFC0002 #36

Merged
merged 7 commits into from
Aug 6, 2015
Merged

Implementation of RFC0002 #36

merged 7 commits into from
Aug 6, 2015

Conversation

kylef
Copy link
Member

@kylef kylef commented Aug 3, 2015

Tasks

@kylef
Copy link
Member Author

kylef commented Aug 5, 2015

This pull request is ready to review, would appreciate if @smizell and @zdne could give a 👍 or 👎.

- `method` (string) - HTTP request method.
- `href` (Href) - A concrete URI for the request.
- `method` (string) - HTTP request method. The method value SHOULD be inherited from a parent transition if it is unset.
- `href` (Href) - A concrete URI for the request. The href SHOULD be inherited from a expanding the any parent transitions href and hrefVariables if the value is unset.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added sentence may need refactoring a bit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a expanding the any parent is illegible.

@smizell
Copy link
Contributor

smizell commented Aug 5, 2015

@kylef looks good to me. Would want Z's thoughts too.

@zdne
Copy link
Member

zdne commented Aug 6, 2015

@kylef @smizell Looks great, merging. 👍

zdne added a commit that referenced this pull request Aug 6, 2015
@zdne zdne merged commit a1b1bab into refractproject:master Aug 6, 2015
@@ -17,6 +17,8 @@ This document extends [Refract][] [Data Structure Namespace][] to define REST Re
- [Resource Elements](#resource-elements)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was renamed below but not here.

@kylef kylef deleted the kylef/rfc-0002 branch August 6, 2015 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants