Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix crash when --distribute option is applied to a run-only test #3081

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Dec 13, 2023

Closes #3074.

@vkarak vkarak added this to the ReFrame 4.5 milestone Dec 13, 2023
@vkarak vkarak self-assigned this Dec 13, 2023
@vkarak vkarak marked this pull request as draft December 13, 2023 20:23
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ca9de6) 86.61% compared to head (c685a46) 86.62%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3081   +/-   ##
========================================
  Coverage    86.61%   86.62%           
========================================
  Files           61       61           
  Lines        12035    12035           
========================================
+ Hits         10424    10425    +1     
+ Misses        1611     1610    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkarak vkarak marked this pull request as ready for review December 13, 2023 20:58
Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit e756287 into reframe-hpc:develop Dec 14, 2023
25 checks passed
@vkarak vkarak deleted the bugfix/distribute-crash-runonly branch December 14, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

--distribute option crashes if build_locally=0 on a run-only test
2 participants