Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packaging] Stricter install requirements in setup.cfg #3135

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Mar 6, 2024

This fixes the failures of the "wheelvalidation" GH action in random PRs after archspec 0.2.3 release which breaks ReFrame. The problem is the following:

The install_requires in our setup.cfg is too loose, stating only the package names not versions. When the CI tries to create the wheel, it fetches the latest archspec which then breaks us. I've made the install_requires stricter to avoid such problems. We should make sure to update also setup.cfg in the next release of archspec.

@vkarak vkarak added this to the ReFrame 4.6 milestone Mar 6, 2024
@vkarak vkarak requested a review from teojgo March 6, 2024 23:16
@vkarak vkarak self-assigned this Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.66%. Comparing base (8395b49) to head (ba6c62f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3135   +/-   ##
========================================
  Coverage    86.66%   86.66%           
========================================
  Files           61       61           
  Lines        12092    12092           
========================================
  Hits         10479    10479           
  Misses        1613     1613           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkarak vkarak force-pushed the packaging/setupcfg-install-reqs branch from 3a494cf to ba6c62f Compare March 6, 2024 23:28
@vkarak vkarak merged commit a01c85b into reframe-hpc:develop Mar 7, 2024
25 checks passed
@vkarak vkarak deleted the packaging/setupcfg-install-reqs branch March 7, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants