-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add support for associating scheduler resources with an environment #3152
[feat] Add support for associating scheduler resources with an environment #3152
Conversation
… feat/env_sched_bind_options_2
Hello @ekouts, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2024-04-18 22:44:40 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3152 +/- ##
========================================
Coverage 86.66% 86.67%
========================================
Files 61 61
Lines 12134 12139 +5
========================================
+ Hits 10516 10521 +5
Misses 1618 1618 ☔ View full report in Codecov by Sentry. |
… feat/env_sched_bind_options_2
Co-authored-by: Theofilos Manitaras <manitaras@cscs.ch>
Co-authored-by: Theofilos Manitaras <manitaras@cscs.ch>
Co-authored-by: Theofilos Manitaras <manitaras@cscs.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should omit completely the env_resources
and simply enable environments to use any of the scheduler resources. This would simplify the implementation and make also more sense at the partition level, as conceptually it doesn't make sense to separate the two types of resources.
… feat/env_sched_bind_options_2
…rame into feat/env_sched_bind_options_2
Co-authored-by: Vasileios Karakasis <vkarak@gmail.com>
…rame into feat/env_sched_bind_options_2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor style changes.
Thanks @vkarak for finishing the PR! |
This is a second attempt for this issue.
I am missing the documentation + unittests but I would like first to agree on the api.It would be very similar to the resources of the test. And the configuration would look like this.
That would translate to the following options in the job script:
Closes #2991 .