Fix paths for Boost Python check #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update python3 test from python3.5 to python3.6. * Use the PYTHONPATH environment variable to extract the python dir.
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 91.26% 91.29% +0.02%
==========================================
Files 67 67
Lines 8005 8005
==========================================
+ Hits 7306 7308 +2
+ Misses 699 697 -2
Continue to review full report at Codecov.
|
vkarak
requested changes
Jun 15, 2018
| @@ -38,4 +38,4 @@ def normalize(s): | |||
|
|
|||
| def _get_checks(**kwargs): | |||
| return [BoostCrayGnuPythonTest('1.65.0', '17.08', '2.7', **kwargs), | |||
| BoostCrayGnuPythonTest('1.65.0', '17.08', '3.5', **kwargs)] | |||
| BoostCrayGnuPythonTest('1.65.0', '17.08', '3.6', **kwargs)] | |||
There was a problem hiding this comment.
I suggest converting the test to the new style.
vkarak
requested changes
Jun 15, 2018
| @@ -1,20 +1,18 @@ | |||
| import os | |||
| def normalize(s): | ||
| return s.replace('.', '_') | ||
|
|
||
| super().__init__('boost_%s_cray_gnu_%s_python_%s_check' % ( | ||
| normalize(boost_version), normalize(cray_gnu_version), | ||
| normalize(python_version)), os.path.dirname(__file__), **kwargs) | ||
| normalize(python_version))) |
There was a problem hiding this comment.
Set the name explicitly, not by passing it to the base class constructor. It may be deprecated in the future.
There was a problem hiding this comment.
And btw I don't think that you need to set it at all. The default name should be fine.
vkarak
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update python3 test from python3.5 to python3.6.
Use the PYTHONPATH environment variable to extract the python dir.