[feat] Evaluate and log all performance values before asserting them #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One can create multiple objectives for a singe test case (see example
below). This commit evaluate and logs all performance values before
asserting them. Thus we can keep better track of all the values observed
during the tests.
Reference example:
```python
p_names = {'creation', 'stat', 'removal'}
for p_name in p_names:
self.perf_patterns[p_name] = sn.extractsingle(r'^\s+File '+p_name+
'\s+:\s+(?P<'+p_name+'>\S+) ', self.stdout, p_name, float)
self.reference = {
'kupe:compute' : {
'creation' : (7747, -(2*223.1)/7747, None),
'stat' : (16527, -(2*558.2)/16527,None),
'removal' : (7355, -(2*173.1)/7355, None)
},
}
```
Plus a small fix in the implementation introduced by the conflict resolution.
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
==========================================
+ Coverage 91.09% 91.11% +0.02%
==========================================
Files 68 68
Lines 8244 8265 +21
==========================================
+ Hits 7510 7531 +21
Misses 734 734
Continue to review full report at Codecov.
|
|
@jenkins-cscs retry daint dom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a useful feature for tests that check multiple performance values.
Replaces #334.