[test] Adapt Tensorflow tests for PE 18.07 #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the new regression test syntax. * Modify the command line options to be in sync with tensorflow 1.7.
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
======================================
Coverage 91.2% 91.2%
======================================
Files 70 70
Lines 8582 8582
======================================
Hits 7827 7827
Misses 755 755Continue to review full report at Codecov.
|
rsarm
approved these changes
Jul 26, 2018
vkarak
approved these changes
Jul 26, 2018
|
|
||
| self.sanity_patterns = sn.all([ | ||
| sn.assert_found(r'INFO:tensorflow:Finished evaluation at', | ||
| self.stderr), | ||
| sn.assert_gt(sn.extractsingle( | ||
| r"Evaluation results:\s+\{.*'accuracy':\s+(?P<accuracy>\S+)" | ||
| r"(?:,|\})", self.stdout, 'accuracy', float), 0.99) | ||
| r"(?:,|\})", self.stdout, 'accuracy', float, -1), 0.99) |
There was a problem hiding this comment.
What was the difference between the first accuracy and the last accuracy value. I mean which one is more correct?
There was a problem hiding this comment.
Now I need to take the final value because there are many accuracy numbers printed throughout the calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new regression test syntax.
Modify the command line options to be in sync with tensorflow 1.7.
Closes #373