[test] Adapt NetCDF test to Kesch #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
requested changes
Sep 28, 2018
| self.valid_prog_environs = ['PrgEnv-pgi-nompi'] | ||
| else: | ||
| self.valid_prog_environs = ['PrgEnv-cray-nompi', | ||
| 'PrgEnv-pgi-nompi'] |
There was a problem hiding this comment.
Rewrite this as
self.valid_prog_environs = ['PrgEnv-pgi-nompi']
if lang != 'f90':
self.valid_prog_environs += ['PrgEnv-cray-nompi']| if self.current_system.name in ['daint', 'dom']: | ||
| self.modules = ['cray-netcdf'] | ||
| elif self.current_system.name in ['kesch']: | ||
| pass |
| '-lnetcdf', | ||
| '-lnetcdf_c++4', | ||
| '-lnetcdff' | ||
| ] |
There was a problem hiding this comment.
This is a clear indication that the PrgEnv-cray-nompi and also the netcdf modules is not properly setup. Have you tried setting the corresponding variables inside the definition of the programming environment in ReFrame.
|
@jenkins-cscs retry dom |
vkarak
approved these changes
Oct 9, 2018
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
==========================================
+ Coverage 91.39% 91.42% +0.02%
==========================================
Files 70 70
Lines 8788 8788
==========================================
+ Hits 8032 8034 +2
+ Misses 756 754 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for some reason the PrgEnv-pgi includes the netcdf library
pgc++, pgf90, ... do not need any -L -l arguments for compiling and linking with netcdf
Prg-Env-cray behaves differently