Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Adapt QE test to PE18.08 #501

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Conversation

lucamar
Copy link
Contributor

@lucamar lucamar commented Oct 9, 2018

Update total energy value: see #375 (comment)

For more information, see the release notes at https://gitlab.com/QEF/q-e/tags/qe-6.2.0

- Some constants in the definition of PBE functionals were truncated to
    6 significant digits. While not a bug, this could lead to tiny differences
    with respect to previous results and other XC implementations (r13592)

Fixes #375.

Update total energy value
@vkarak vkarak self-requested a review October 9, 2018 13:41
@vkarak vkarak added this to the Upcoming sprint milestone Oct 9, 2018
@vkarak vkarak changed the title Update espresso_check.py [test] Adapt QE test to PE18.08 Oct 9, 2018
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @lucamar.

@vkarak
Copy link
Contributor

vkarak commented Oct 9, 2018

@jenkins-cscs retry dom

@codecov-io
Copy link

Codecov Report

Merging #501 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
- Coverage   91.41%   91.39%   -0.03%     
==========================================
  Files          72       72              
  Lines        8737     8737              
==========================================
- Hits         7987     7985       -2     
- Misses        750      752       +2
Impacted Files Coverage Δ
reframe/core/config.py 82.6% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85481a6...7ac02d9. Read the comment docs.

@vkarak vkarak merged commit b841287 into reframe-hpc:master Oct 9, 2018
@lucamar lucamar deleted the patch-2 branch October 9, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants