Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Adapt IOR checks to build systems #505

Merged
merged 4 commits into from
Oct 11, 2018
Merged

[test] Adapt IOR checks to build systems #505

merged 4 commits into from
Oct 11, 2018

Conversation

teojgo
Copy link
Contributor

@teojgo teojgo commented Oct 11, 2018

Fixes #497

@teojgo teojgo added this to the ReFrame sprint 2018w41 milestone Oct 11, 2018
@teojgo teojgo self-assigned this Oct 11, 2018
@teojgo teojgo requested a review from vkarak October 11, 2018 09:45
@teojgo
Copy link
Contributor Author

teojgo commented Oct 11, 2018

@jenkins-cscs retry dom

vkarak
vkarak requested changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems also that the maintenance tag has been disappeared. Filtering the tests with -t maintenance yields nothing.

cscs-checks/system/io/ior_check.py Outdated
'-D 300 -k -o %s' % self.test_file).split()
self.executable_opts = ['-r', '-a MPIIO', '-B', '-E', '-F',
'-t 64m', '-b 32g', '-D 300', '-k',
' -o %s' % self.test_file]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[..., '-o', self.test_file]

cscs-checks/system/io/ior_check.py Outdated
@@ -179,13 +196,15 @@ def __init__(self, name, fs_mount_point, ior_type, num_tasks, **kwargs):
self.tags = {'monch_acceptance'}


@rfm.parameterized_test(*(['/mnt/lnec', 'MPIIO', task]
for task in [40, 80, 160]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task -> num_tasks or nt.

@teojgo
Copy link
Contributor Author

teojgo commented Oct 11, 2018

There was no maintenance tag, there was the ops one.

@vkarak
Copy link
Contributor

vkarak commented Oct 11, 2018

@teojgo No, there should be a maintenance tag:

  • On master:
./bin/reframe -C config/cscs.py -c cscs-checks/system/io/ior_check.py -t maintenance -l

List of matched checks
======================
  * ior_read_check_users (found in /users/karakasv/Devel/reframe/cscs-checks/system/io/ior_check.py)
        descr: IOR check (/users)
        tags: {/users,read,ops,maintenance}, maintainers: ['SO', 'MP']
  * ior_write_check_users (found in /users/karakasv/Devel/reframe/cscs-checks/system/io/ior_check.py)
        descr: IOR check (/users)
        tags: {/users,write,ops,maintenance}, maintainers: ['SO', 'MP']
Found 2 check(s).
  • On your branch
List of matched checks
======================
Found 0 check(s).

@codecov-io
Copy link

codecov-io commented Oct 11, 2018 •
edited
Loading

Codecov Report

Merging #505 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #505   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          72       72           
  Lines        8737     8737           
=======================================
  Hits         7985     7985           
  Misses        752      752

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d608a...ff244d6. Read the comment docs.

@vkarak vkarak merged commit 7fa7b74 into reframe-hpc:master Oct 11, 2018
@teojgo teojgo deleted the regression_test/ior_build_systems branch October 11, 2018 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarak vkarak vkarak approved these changes

Assignees

@teojgo teojgo

Labels
enhancement prio: normal
Projects
None yet
Milestone
ReFrame sprint 2018w41
Development

Successfully merging this pull request may close these issues.
3 participants
@teojgo @vkarak @codecov-io