Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Run libsci_acc and libsci_resolve tests on compute nodes as well #581

Merged
merged 3 commits into from
Nov 14, 2018
Merged

[test] Run libsci_acc and libsci_resolve tests on compute nodes as well #581

merged 3 commits into from
Nov 14, 2018

Conversation

teojgo
Copy link
Contributor

@teojgo teojgo commented Nov 13, 2018 •
edited
Loading

  • In addition, adapt the tests to the new syntax.

Closes #538

@teojgo
Run libsci_acc and libsci_resolve in compute nodes
d42e942 
* In addition, adapt the tests to the new syntax.
@teojgo teojgo added this to the ReFrame sprint 2018w44 milestone Nov 13, 2018
@teojgo teojgo self-assigned this Nov 13, 2018
vkarak
vkarak approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except for a minor comment.

cscs-checks/compile/libsci_acc_symlink.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #581 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          72       72           
  Lines        8954     8954           
=======================================
  Hits         8201     8201           
  Misses        753      753

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14cd5ac...96a800d. Read the comment docs.

@vkarak vkarak changed the title [test] Run libsci_acc and libsci_resolve in compute nodes [test] Run libsci_acc and libsci_resolve tests on compute nodes as well Nov 14, 2018
@vkarak vkarak merged commit e3f918c into reframe-hpc:master Nov 14, 2018
@teojgo teojgo deleted the regression_test/libsci_acc_compute_nodes branch November 22, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarak vkarak vkarak approved these changes

@ajocksch ajocksch Awaiting requested review from ajocksch

Assignees

@teojgo teojgo

Labels
prio: normal
Projects
None yet
Milestone
ReFrame sprint 2018w44
Development

Successfully merging this pull request may close these issues.
3 participants
@teojgo @codecov-io @vkarak