Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option name doesn't match help text #12

Closed
drtconway opened this issue Jun 24, 2020 · 3 comments
Closed

Option name doesn't match help text #12

drtconway opened this issue Jun 24, 2020 · 3 comments
Assignees
@agudys

Comments

@drtconway
Copy link

Line 73 of whisper.cpp prints the help text calling the option "-gzipped-SAM-level"

Line 171 matches against "-gzipped-SAM"
@drtconway
Copy link
Author

Can I recommend using an options library, so you don't have duplicate definitions, and lots of duplicated code?

I've used boost program_options, which is ok.

Docopt is awesome as well - not quite as good in C++ as it is in Python, et al, but still an improvement.

@agudys agudys self-assigned this Jun 24, 2020
@agudys
Copy link
Member

agudys commented Jun 24, 2020

Thanks for pointing this out! The number of options has grown so much that we definately need to handle command line parameters more systematically.

agudys added a commit that referenced this issue Jul 2, 2020
@agudys
Fixed inconsistencies in README and help messages. Fixed bug in comma…
7586d70 
…nd line arguments control (#10, #11, #12, #13).
@agudys agudys mentioned this issue Jul 2, 2020
Merged
@agudys
Copy link
Member

agudys commented Jul 2, 2020

@drtconway
The bug has been, hopefully fixed in the latest release.

@agudys agudys closed this as completed Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agudys agudys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agudys @drtconway