comment-report-format option allows to summarize report comment by each changed file #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krrrr38
changed the title
krrrr38
changed the title
|
@krrrr38 Thanks for you PR. Looks good 👍 |
bokuweb
added a commit
that referenced
this pull request
Jul 17, 2024
* Update README.md * fix: 103 (#104) * fix: comment (#105) Co-authored-by: bokuweb <bokuweb@bokuwebnoair.lan> * feat: comment-report-format option allow to summarize changed file comment format (#107) * fix: `The disable-branch option is not working` (#112) * test * test * test * test * fix: input * fix: report generation (#113) * deps: update (#114) * build(deps): bump follow-redirects from 1.15.2 to 1.15.4 (#106) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: bokuweb <bokuweb12@gmail.com> * Delete yarn.lock * build(deps): bump undici from 5.28.3 to 5.28.4 (#120) Bumps [undici](https://github.com/nodejs/undici) from 5.28.3 to 5.28.4. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.3...v5.28.4) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: 118 (#121) * fix: #118 (#122) * feat: add cleanup workspace directory (#124) * handle: error (#125) * fix: handle comment size limitation (#126) * Update comment.ts (#128) * chore: add logs (#129) * chore: add logs (#130) * fix * fix * chore: update deps (#131) * feat: add link for artifact (#133) * deps: update deps (#132) * fix: use artifact client for download (#135) * fix: use artifact client for download * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * Revert "fix: use artifact client for download (#135)" (#136) This reverts commit 19d3918. * feat: outdated comment action option to minimize previous reg-action comments (#138) * feat: Support retention days (#139) * feat: Support retention days * test * test * test * remove test * green keep (#140) * fix retention-days input parameter (#141) * chore: add log (#142) * fix: use for (#143) * fix (#144) * fix: replace client (#145) * Revert "fix: replace client (#145)" (#146) This reverts commit 60a8105. * fix: threshold-pixel param default overrides threshold-rate (#147) Allows threshold-pixel value to be null as well, if not defined. That way, when specifying threshold-rate, only the threshold-rate will be applied. Otherwise threshold-rate does not have any effect, since it will always be overriden by threshold-pixel that defaults to 0. * feat: allow specifying expected images directory This way, it is not needed to find previous runs and download an artifact. Instead, the images are copied from the expected images directory and compared immediately. * add missing property into action.yml * revert back to using targetRun parameter * fix validation of expectedImagesDirectoryPath * do not allow empty expectedImagesDirectoryPath if it's defined * Remove `allowEmpty` from `validateImageDirPath` --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: bokuweb <bokuweb12@gmail.com> Co-authored-by: bokuweb <bokuweb@bokuwebnoair.lan> Co-authored-by: Ken Kaizu <k.kaizu38@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yuki Mima <amyu@r.recruit.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we have multiple file changes, sometimes we want to view only a specific changed file. Current comment format is difficult to find a specific changed file.
Solution
Add a
comment-report-format: "summarized"config. It make add more<details>tag into each changed file.Debug
just kick sample repository using forked github action.
with `comment-report-format: "summarized"` config
reports can be expanded by each file.
without `comment-report-format` config
no changed behaviors.