Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore error when failed to instantiate worker #64

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

bokuweb
Copy link
Member

@bokuweb bokuweb commented Aug 15, 2024

What does this change?

ignore worker instantiate error. ref: reg-viz/reg-cli#506
I think it is better to continue rendering report if failed to instantiate worker.

References

reg-viz/reg-cli#506

Screenshots

NA

What can I check for bug fixes?

NA

@bokuweb bokuweb requested a review from wadackel August 15, 2024 06:16
Copy link
Collaborator

@wadackel wadackel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx ❤️

@wadackel wadackel merged commit 9198450 into main Aug 18, 2024
5 checks passed
@wadackel wadackel deleted the ignore-worker-instantiate-error branch August 18, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants