Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enableACL option to s3-publisher-plugin #602

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Add enableACL option to s3-publisher-plugin #602

merged 2 commits into from
Jul 4, 2023

Conversation

kurochan
Copy link
Contributor

What does this change?

AWS recommends disabling ACLs in S3, so add an option to use ACLs or not.
Default is to enable for backward compatibility.

References

@Quramy Quramy merged commit 6884565 into reg-viz:master Jul 4, 2023
@kurochan
Copy link
Contributor Author

kurochan commented Jul 4, 2023 •
edited
Loading

I've checked v0.12.2 and it works correctly with S3 ACLs disabled. Thank you for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurochan @Quramy