Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to upgrade module #13

Closed
7 tasks done
aaronc opened this issue Mar 24, 2019 · 0 comments
Closed
7 tasks done

Improvements to upgrade module #13

aaronc opened this issue Mar 24, 2019 · 0 comments
Assignees

Comments

@aaronc
Copy link
Member

aaronc commented Mar 24, 2019

Motivation: cosmos sometimes pushes breaking changes to the genesis config that would force us to recreate our testnet. We shouldn't be lazy and tear down our testnet every time something like this happens and we actually need a more graceful way to deal with it in production.

  • the upgrade keeper should allow for some "on upgrade" code to be called whenever a chain restarts after a scheduled upgrade. This upgrade code can perform state changes necessary to support the upgrade before any other transactions are processed (so it should happen in the BeginBlocker)
  • allow upgrades based on time or block height
  • make the module as simple as possible but not simpler
  • thorough docs, run golintand make sure there are tutorial docs
  • thorough test coverage
  • adapt Postgres indexer package to properly support migrations and integrate them with upgrade module for testnet
  • add cli query and REST support, and possibly a cli tx cmd helper
@aaronc aaronc added this to the 0.4 milestone Mar 24, 2019
@aaronc aaronc added the backlog label Mar 24, 2019
@ghost ghost assigned aaronc Mar 25, 2019
@ghost ghost added Status: In Progress and removed backlog labels Mar 25, 2019
@aaronc aaronc changed the title On upgrade hook support Improvements to upgrade module Mar 25, 2019
aaronc added a commit that referenced this issue Mar 25, 2019
… time (the store would get checked every time there is no upgrade anyway)
aaronc added a commit that referenced this issue Mar 25, 2019
aaronc added a commit that referenced this issue Mar 26, 2019
aaronc added a commit that referenced this issue Mar 26, 2019
aaronc added a commit that referenced this issue Mar 26, 2019
@ghost ghost removed the Status: In Progress label Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant