Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixed fee for creating a new credit class #351

Closed
3 tasks
clevinson opened this issue May 13, 2021 · 3 comments · Fixed by #375
Closed
3 tasks

Add fixed fee for creating a new credit class #351

clevinson opened this issue May 13, 2021 · 3 comments · Fixed by #375
Assignees
@ruhatch
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module
Milestone
v2.0 - Baikal Upg...

Comments

@clevinson
Copy link
Member

clevinson commented May 13, 2021 •
edited by robert-zaremba
Loading

At first this should just involve sending fees to the fee pool, but eventually could change to send fees to some "credit class governance body" who stewards the larger set of on-chain credit classes.

  • write specification
  • decide about the pledge mechanism
  • decide about the community pool
@aaronc aaronc mentioned this issue May 13, 2021
Closed
7 tasks
@aaronc aaronc added the Scope: x/ecocredit Issues that update the x/ecocredit module label May 13, 2021
@aaronc aaronc added this to the v1.1 milestone May 21, 2021
@robert-zaremba
Copy link
Collaborator

Fee should be on-chain parameter - governed by REGEN holders.
TODO: need to decide about the process and what happens with the fee (burned vs some pool).

@robert-zaremba
Copy link
Collaborator

Here is my proposal for what to do with fees:

  • 34% will be burned
  • 66% will go to a community pool. Funds from this pool will be used create gitcoin grants for building ecosystem around eco-credits.

@ruhatch ruhatch self-assigned this Jun 4, 2021
ruhatch added a commit that referenced this issue Jun 7, 2021
@ruhatch
[#351] Add fixed fee for creating a new credit class
34df62b
ruhatch added a commit that referenced this issue Jun 8, 2021
@ruhatch
[#351] Add fixed fee for creating a new credit class
2b9db4c
@ruhatch ruhatch mentioned this issue Jun 8, 2021
Merged
ruhatch added a commit that referenced this issue Jun 8, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
72123c8
ruhatch added a commit that referenced this issue Jun 8, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
390e29f
ruhatch added a commit that referenced this issue Jun 9, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
2b6eacc
ruhatch added a commit that referenced this issue Jun 9, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
9c20112
ruhatch added a commit that referenced this issue Jun 9, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
a454fdf
ruhatch added a commit that referenced this issue Jun 9, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
4f52a56
@ruhatch
Copy link
Contributor

ruhatch commented Jun 10, 2021

I've opened a discussion to continue making the decision about what to do with the fees.

ruhatch added a commit that referenced this issue Jun 14, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
0a40b77
ruhatch added a commit that referenced this issue Jun 14, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
1bc7219
ruhatch added a commit that referenced this issue Jun 14, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
15d827f
ruhatch added a commit that referenced this issue Jun 14, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
4ec6adc
ruhatch added a commit that referenced this issue Jun 14, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
7dec40d
ruhatch added a commit that referenced this issue Jun 14, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
2957585
ruhatch added a commit that referenced this issue Jun 16, 2021
@ruhatch
feat: Add fixed fee for creating a new credit class (#351)
f7b6d2f 
This commit adds a fixed fee to the CreateClass method of `x/ecocredit`.

The fee is:
- charged to the `Designer` of the new class
- based on a global `x/params` parameter, updated through `x/gov`
- currently burned, but in future might be placed in a community pool, as per #383

Closes #351
@clevinson clevinson mentioned this issue Aug 24, 2021
Closed
@ryanchristo ryanchristo mentioned this issue Mar 31, 2022
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruhatch ruhatch

Labels
Scope: x/ecocredit Issues that update the x/ecocredit module
Projects
None yet
Milestone
v2.0 - Baikal Upgrade
Development

Successfully merging a pull request may close this issue.

feat: Add fixed fee for creating a new credit class (#351) regen-network/regen-ledger
4 participants
@aaronc @robert-zaremba @clevinson @ruhatch