Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ecocredit marketplace to v1 #856

Closed
12 of 16 tasks
Tracked by #818
ryanchristo opened this issue Mar 8, 2022 · 1 comment · Fixed by #969
Closed
12 of 16 tasks
Tracked by #818

Migrate ecocredit marketplace to v1 #856

ryanchristo opened this issue Mar 8, 2022 · 1 comment · Fixed by #969
Assignees
@technicallyty
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature
Milestone
v4.0 - Llangorse ...

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Mar 8, 2022 •
edited by zube bot
Loading

Summary

Ref: #696

The proto API for marketplace v1 uses the new ORM storage model. We need to migrate the existing marketplace message and query server implementations to use marketplace v1.

txs:

queries:

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo ryanchristo added the Scope: x/ecocredit Issues that update the x/ecocredit module label Mar 8, 2022
@ryanchristo ryanchristo added this to the v4.0 - Llangorse Upgrade milestone Mar 8, 2022
@ryanchristo ryanchristo mentioned this issue Mar 8, 2022
Closed
@technicallyty technicallyty self-assigned this Mar 9, 2022
This was referenced Mar 9, 2022
Merged
Closed
This was referenced Mar 10, 2022
Merged
Merged
Merged
This was referenced Mar 17, 2022
Merged
Merged
Merged
Merged
@ryanchristo
Copy link
Member Author

ryanchristo commented Mar 27, 2022 •
edited
Loading

Almost there! AllowAskDenom should not be a blocked. The only blocker should be checking if provided bid and ask denoms in buy and sell orders are included in AllowAskDenom. (#624)

@ryanchristo ryanchristo mentioned this issue Apr 2, 2022
Merged
19 tasks
@ryanchristo ryanchristo added the Type: Refactor A code change that neither fixes a bug nor adds a feature label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@technicallyty technicallyty

Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
v4.0 - Llangorse Upgrade
Development

Successfully merging a pull request may close this issue.

feat(ecocredit/marketplace): AllowAskDenom parameter regen-network/regen-ledger
2 participants
@ryanchristo @technicallyty