Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(marketplace): update sell orders ORM #903

Merged
merged 16 commits into from
Mar 25, 2022

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Mar 17, 2022

Description

  • adds UpdateSellOrders to marketplace submodule

ref: #856


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #903 (0f17d79) into master (70f0264) will increase coverage by 0.55%.
The diff coverage is 71.57%.

❗ Current head 0f17d79 differs from pull request most recent head f33a272. Consider uploading reports for the commit f33a272 to get more accurate results

@@            Coverage Diff             @@
##           master     #903      +/-   ##
==========================================
+ Coverage   72.42%   72.97%   +0.55%     
==========================================
  Files         194      194              
  Lines       22900    22763     -137     
==========================================
+ Hits        16585    16612      +27     
+ Misses       5073     4894     -179     
- Partials     1242     1257      +15     
Flag Coverage Δ
experimental-codecov 72.88% <71.57%> (+0.62%) ⬆️
stable-codecov 66.15% <71.57%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@technicallyty technicallyty marked this pull request as ready for review March 17, 2022 08:16
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@technicallyty technicallyty enabled auto-merge (squash) March 25, 2022 19:30
@technicallyty technicallyty merged commit 909e051 into master Mar 25, 2022
@technicallyty technicallyty deleted the ty/856-update_sell_orders branch March 25, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants