Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate sdk.Msg implementations to target v1 #900

Closed
4 tasks
Tracked by #818
technicallyty opened this issue Mar 16, 2022 · 0 comments · Fixed by #911
Closed
4 tasks
Tracked by #818

Migrate sdk.Msg implementations to target v1 #900

technicallyty opened this issue Mar 16, 2022 · 0 comments · Fixed by #911
Assignees
@technicallyty
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature
Milestone
v4.0 - Llangorse ...

Comments

@technicallyty
Copy link
Contributor

technicallyty commented Mar 16, 2022 •
edited
Loading

Summary

Once the new submodules are wired into the app (#898), we need to also migrate the sdk.Msg implementations (ValidateBasic) (GetSigners) to target V1 proto types.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@technicallyty technicallyty mentioned this issue Mar 16, 2022
Closed
@ryanchristo ryanchristo added this to the v4.0 - Llangorse Upgrade milestone Mar 16, 2022
@ryanchristo ryanchristo added Scope: x/ecocredit Issues that update the x/ecocredit module Status: Blocked labels Mar 16, 2022
@technicallyty technicallyty mentioned this issue Mar 19, 2022
Merged
19 tasks
@technicallyty technicallyty self-assigned this Mar 19, 2022
@ryanchristo ryanchristo added the Type: Refactor A code change that neither fixes a bug nor adds a feature label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@technicallyty technicallyty

Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
v4.0 - Llangorse Upgrade
Development

Successfully merging a pull request may close this issue.

chore: copy sdk.Msg impls for v1 regen-network/regen-ledger
2 participants
@ryanchristo @technicallyty