Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: copy sdk.Msg impls for v1 #911

Merged
merged 8 commits into from
Mar 20, 2022
Merged

chore: copy sdk.Msg impls for v1 #911

merged 8 commits into from
Mar 20, 2022

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Mar 19, 2022

Description

  • copies the sdk.Msg impls from alpha proto to v1 protos.
  • also ran go fmt in the ecocredit module

reviewers: 99.99% of this is just copy pasta, any additl' edits made were cleanup and adding t.Parallel() to all the msg tests.

Closes: #900


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #911 (edf3fac) into master (ab646ff) will decrease coverage by 0.70%.
The diff coverage is 25.40%.

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
- Coverage   73.37%   72.67%   -0.71%     
==========================================
  Files         171      184      +13     
  Lines       22493    22735     +242     
==========================================
+ Hits        16505    16523      +18     
- Misses       4820     4987     +167     
- Partials     1168     1225      +57     
Flag Coverage Δ
experimental-codecov 72.46% <15.98%> (-0.89%) ⬇️
stable-codecov 65.77% <17.21%> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

x/ecocredit/marketplace/msg_buy.go Outdated Show resolved Hide resolved
x/ecocredit/basket/msg_create_test.go Outdated Show resolved Hide resolved
x/ecocredit/basket/msg_create_test.go Outdated Show resolved Hide resolved
x/ecocredit/basket/msg_create_test.go Outdated Show resolved Hide resolved
x/ecocredit/basket/msg_create_test.go Outdated Show resolved Hide resolved
x/ecocredit/basket/msg_create_test.go Outdated Show resolved Hide resolved
x/ecocredit/basket/msg_create_test.go Outdated Show resolved Hide resolved
x/ecocredit/basket/msg_create_test.go Outdated Show resolved Hide resolved
technicallyty and others added 3 commits March 19, 2022 10:59
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
@ryanchristo ryanchristo merged commit 6661ec4 into master Mar 20, 2022
@ryanchristo ryanchristo deleted the ty/900-msg_impl branch March 20, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate sdk.Msg implementations to target v1
3 participants