Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(x/ecocredit): basket put acceptance tests #1065

Merged
merged 18 commits into from
May 9, 2022
Merged

test(x/ecocredit): basket put acceptance tests #1065

merged 18 commits into from
May 9, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Apr 28, 2022 •
edited by zube bot
Loading

Description

Ref: #895

This pull request updates and implements basket put acceptance tests.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

Merging #1065 (97336a6) into master (3841ec5) will decrease coverage by 6.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
- Coverage   68.07%   61.86%   -6.22%     
==========================================
  Files         210      207       -3     
  Lines       20956    19082    -1874     
==========================================
- Hits        14266    11805    -2461     
- Misses       5366     6031     +665     
+ Partials     1324     1246      -78
Flag Coverage Δ
experimental-codecov ?
stable-codecov 61.86% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo requested a review from aaronc April 28, 2022 18:51
@ryanchristo ryanchristo changed the title test(x/ecocredit): basket acceptance tests test(x/ecocredit): basket put acceptance tests May 5, 2022
@ryanchristo ryanchristo marked this pull request as ready for review May 5, 2022 20:37
technicallyty
technicallyty reviewed May 6, 2022
View reviewed changes
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! cool to see some robust gocuke tests.

just a few nits and concern with testing mock behavior

x/ecocredit/core/utils.go Show resolved Hide resolved
x/ecocredit/server/basket/keeper_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/basket/msg_put_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/basket/msg_put_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/basket/msg_put_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/basket/msg_put_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/basket/msg_put_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/basket/msg_put_test.go Show resolved Hide resolved
x/ecocredit/server/basket/msg_put_test.go Show resolved Hide resolved
technicallyty
technicallyty approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just a sneaky file leftover 🥷

x/ecocredit/core/TestUtils_GetCreditTypeAbbrevFromClassId-20220505172009-3191812.fail Outdated Show resolved Hide resolved
aleem1314
aleem1314 approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo enabled auto-merge (squash) May 9, 2022 15:39
@ryanchristo ryanchristo merged commit fae569f into master May 9, 2022
@ryanchristo ryanchristo deleted the ryan/895-basket-tests branch May 9, 2022 15:44
@ryanchristo ryanchristo mentioned this pull request May 20, 2022
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technicallyty technicallyty technicallyty approved these changes

@aleem1314 aleem1314 aleem1314 approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@clevinson clevinson Awaiting requested review from clevinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanchristo @technicallyty @aleem1314